Several improvements: Support move semantic + remove vector in favour of std one + add support for std::string with -D DASH_USE_STL_STRING=1 #245
+153
−336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
mathieucarbou
force-pushed
the
dev
branch
3 times, most recently
from
db80f53 to
03fd807
Compare
mathieucarbou
changed the title
mathieucarbou
changed the title
mathieucarbou
changed the title
|
@ayushsharma82 : FYI. I also have the same commits for the pro version in my dev branch. I refreshed them just now (minor cleanups) and rebased. |
|
Thanks @mathieucarbou , I'll merge everything in upcoming days. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several improvements in this PR:
1) using std::vector instead of current vector class
2)Support for move semantic for strings to avoid a buffer copy for rvalues
Move semantic allows to avoid a second buffer copy when calling ESP-DASH with rvalues like that:
The created buffer will directly be transferred to the internal class, which reduces heap fragmentation.
These
update()calls being frequently called so this is a relevant optimizaiton.3) add support for std::string with -D DASH_USE_STL_STRING=1